Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for user set health check interval #92

Closed
wants to merge 1 commit into from
Closed

Add support for user set health check interval #92

wants to merge 1 commit into from

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented Apr 15, 2024 •
edited
Loading

closes #91

Description

Maps healthCheckInterval into settings so that a user set value can be passed to the Launcher.start call
NOTES:

Related Issue(s)

#91

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

This was referenced Apr 15, 2024
Merged
Closed
Merged
Merged
@Steve-Mcl Steve-Mcl requested a review from hardillb April 15, 2024 11:46
@knolleary
Copy link
Member

Proposing this is closed - FlowFuse/flowfuse#3578 (comment)

@Steve-Mcl
Copy link
Contributor Author

Proposing this is closed - FlowFuse/flowfuse#3578 (comment)

Agreed & tested by implementing this in /settings api endpoint in the forge app https://github.com/FlowFuse/flowfuse/blob/main/forge/routes/api/project.js#L798 as suggested in the linked comment.

Closing.

@Steve-Mcl Steve-Mcl closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardillb hardillb hardillb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Instance Health Check interval to be configured
3 participants
@Steve-Mcl @knolleary @hardillb